Tarkista lommakkeella tallennettavien määräysryhmien lyhyet nimet #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now PlanManager has a variable for reg. groups from active plan that is updated when needed. Previously all regulation groups were read from DB every time reg. groups from active plan were needed for some form.
nmaarnio
force-pushed
the
158-tarkistus-siitä-ettei-käyttäjä-ole-lisäämässä-määräysryhmää-olemassa-olevalla-lyhyellä-nimellä
branch
from
c200e5c to
d1800d0
Compare
LKajan
approved these changes
Feb 21, 2025
| @@ -57,7 +62,9 @@ def __init__( | |||
| self.regulation_groups_tree_layout: QVBoxLayout | |||
|
|
|||
| # INIT | |||
| self.regulation_group_libraries = regulation_group_libraries | |||
| self.existing_group_short_names = active_plan_regulation_groups_library.get_short_names() | |||
There was a problem hiding this comment.
Voisi muuttaa set:ksi, niin haku tehokkaampaa. Ei nyt oikeesti tässä mittaluokassa merkittävää.
Tai sitten tuon get_short_names() voisi muuttaa palauttamaan suoraan set:n.
Suggested change
| self.existing_group_short_names = active_plan_regulation_groups_library.get_short_names() | |
| self.existing_group_short_names = set(active_plan_regulation_groups_library.get_short_names()) |
arho_feature_template/core/models.py
Outdated
Comment on lines
149
to
157
| def get_short_names(self) -> list[str]: | ||
| """Returns list of non-empty short names (letter codes) of regulation groups part of the library.""" | ||
| short_names = [] | ||
| for category in self.regulation_group_categories: | ||
| for regulation_group in category.regulation_groups: | ||
| short_name = regulation_group.short_name | ||
| if short_name: | ||
| short_names.append(short_name) | ||
| return short_names |
There was a problem hiding this comment.
Saisi hoidettua yhdellä list comprehensionilla, mutta en sitte tiiä kumpi on selkolukuisempi.
Tai oikeestaan, jos ei järjestyksellä tai duplikaateilla ole merkitystä, niin voisi muuttaa palauttamaan suoraan set:n, jolloin haku tästä olisi tehokkaampaa.
Suggested change
| def get_short_names(self) -> list[str]: | |
| """Returns list of non-empty short names (letter codes) of regulation groups part of the library.""" | |
| short_names = [] | |
| for category in self.regulation_group_categories: | |
| for regulation_group in category.regulation_groups: | |
| short_name = regulation_group.short_name | |
| if short_name: | |
| short_names.append(short_name) | |
| return short_names | |
| def get_short_names(self) -> set[str]: | |
| return { | |
| regulation_group.short_name | |
| for category in self.regulation_group_categories | |
| for regulation_group in category.regulation_groups | |
| if regulation_group.short_name | |
| } |
nmaarnio
force-pushed
the
158-tarkistus-siitä-ettei-käyttäjä-ole-lisäämässä-määräysryhmää-olemassa-olevalla-lyhyellä-nimellä
branch
from
d1800d0 to
ab824b3
Compare
nmaarnio
deleted the
158-tarkistus-siitä-ettei-käyttäjä-ole-lisäämässä-määräysryhmää-olemassa-olevalla-lyhyellä-nimellä
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.